Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid placement for v3.0.x #3858

Merged
merged 4 commits into from Feb 15, 2018
Merged

Conversation

talaj
Copy link
Member

@talaj talaj commented Feb 14, 2018

Port of #3847 to v3.0.x, including fixes from #3855.

cc @kocio-pl

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #3858 into v3.0.x will increase coverage by 0.08%.
The diff coverage is 93.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v3.0.x    #3858      +/-   ##
==========================================
+ Coverage   65.28%   65.37%   +0.08%     
==========================================
  Files         443      444       +1     
  Lines       21815    21932     +117     
==========================================
+ Hits        14243    14337      +94     
- Misses       7572     7595      +23
Impacted Files Coverage Δ
include/mapnik/text/symbolizer_helpers.hpp 0% <ø> (ø) ⬆️
src/symbolizer_enumerations.cpp 100% <ø> (ø) ⬆️
include/mapnik/text/text_properties.hpp 0% <ø> (ø) ⬆️
src/load_map.cpp 78.3% <100%> (+0.05%) ⬆️
src/text/text_properties.cpp 67% <60%> (-0.37%) ⬇️
src/text/symbolizer_helpers.cpp 95.57% <95.34%> (-0.37%) ⬇️
include/mapnik/grid_vertex_converter.hpp 96.05% <96.05%> (ø)
...clude/mapnik/geometry/polygon_vertex_processor.hpp 0% <0%> (-100%) ⬇️
src/image_util.cpp 39.48% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb070c...f91d37d. Read the comment docs.

@kocio-pl
Copy link

kocio-pl commented Mar 4, 2018

@artemp This change (together with #3846 bugfix) is quite interesting for me for testing and deploying on OSMF servers, since v3.0.18 is flawed. Do you plan to release v3.0.19 in some near future?

@artemp
Copy link
Member

artemp commented Mar 5, 2018

@kocio-pl - the short answer is yes.

@artemp artemp added this to the v3.0.19 milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants