-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace majority of boost->std optional and boost->std string_view #4445
Conversation
3b87b5a
to
e184b09
Compare
e184b09
to
21276ab
Compare
@artemp There are some missing bits, where the optional value type has a reference type. I would do these in a seperate PR, as depending on the approch taken, would be a bit more code change then just renaming. |
@artemp could you review this? |
@mathisloge looks good, going to merge! |
|
Yeah, that would be one way, with the least intrusive change. |
No description provided.