Use curies.Converter more natively
#401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
commented
Jul 28, 2023
matentzn
reviewed
Jul 28, 2023
src/sssom/context.py
Outdated
| ) | ||
| return prefix_map | ||
| converter = Converter.from_prefix_map(prefix_map) | ||
| return curies.chain([converter, get_built_in_converter()]) |
There was a problem hiding this comment.
cool this is possible but not needed anymore: we just use the bioregistry converter and make sure through unit testing that it never violates our prefix preferences when updating the EPM.
src/sssom/parsers.py
Outdated
| @@ -556,7 +561,7 @@ def from_sssom_rdf( | |||
|
|
|||
| ms.mappings = mlist # type: ignore | |||
| _set_metadata_in_mapping_set(mapping_set=ms, metadata=meta) | |||
| mdoc = MappingSetDocument(mapping_set=ms, prefix_map=prefix_map) | |||
| mdoc = MappingSetDocument(mapping_set=ms, prefix_map=converter.prefix_map) | |||
There was a problem hiding this comment.
Next step will be replace the prefix_map object in the mapping set document with a converter directly
|
Lost track of this. @cthoyt I know you will be swamped, so let me know when this is ready for review. |
|
This has been split into many other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #418
This PR is the next step towards using
curies.Converter.prefix_mapinside theMetadatadefinition with aconverter. Next steps are to do this for all models.curies.chainas the one true implementation