Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pruned dependencies #404

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Pruned dependencies #404

merged 2 commits into from
Aug 7, 2023

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Aug 4, 2023

Removed:

  • bioregistry

@hrshdhgd hrshdhgd marked this pull request as ready for review August 4, 2023 19:46
matentzn
matentzn approved these changes Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this but it seems at first glance to interact heavily with #401. Can you make sure that PR is updated when this is merged?

@hrshdhgd hrshdhgd merged commit 52f2d54 into master Aug 7, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the dependency-update branch August 7, 2023 13:41
@cmungall
Copy link
Collaborator

cmungall commented Aug 7, 2023

Do they in fact interact?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Aug 7, 2023

I merged the main branch into that one and there seemed to be no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@cmungall cmungall Awaiting requested review from cmungall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hrshdhgd @cmungall @matentzn