Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sssom-schema #510

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Update sssom-schema #510

merged 4 commits into from
Apr 2, 2024

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Apr 1, 2024

ran poetry add sssom-schema@latest

@hrshdhgd hrshdhgd requested a review from matentzn April 1, 2024 14:29
matentzn
matentzn previously approved these changes Apr 1, 2024
@matentzn
Copy link
Collaborator

matentzn commented Apr 1, 2024

Some stuff broke?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Apr 1, 2024

Yes the test is failing because the rdf test file does not have subject_id. Did we use some other file to convert to rdf. I can recreate it?

@matentzn
Copy link
Collaborator

matentzn commented Apr 2, 2024

The RDF file does have a subject_id, but it is mapped to some other relation. Check Slack for details.

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Apr 2, 2024

This also passes now

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@hrshdhgd hrshdhgd merged commit be8a77b into master Apr 2, 2024
6 checks passed
@hrshdhgd hrshdhgd deleted the schema-update branch April 2, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants