-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing sssom-schema update #511
base: master
Are you sure you want to change the base?
Conversation
Updates:
|
python = "^3.9" | ||
click = ">=8.1.7" | ||
curies = ">=0.7.8" | ||
pandas = ">=2.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause a problem like it did with #432
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might, but we can solve it on the cat-merge / kgx side this time, I say go for it
pyyaml = "^6.0.1" | ||
rdflib = ">=6.0.0" | ||
PyYAML = "^6.0.1" | ||
rdflib = ">=7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty steep. Necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well if it isn't breaking for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this to draft mode because:
- I am worried of breaking the monarch pipelines again with pandas 2
- Chris suggests to introduce 3.9+ dependencies in a separate release
Here are the steps that were followed in this branch
sssom convert https://raw.githubusercontent.com/mapping-commons/sssom-py/master/tests/data/basic.tsv -o tests/data/basic.sssom2.rdf -O rdf
self.rdf_graph_file = f"{test_data_dir}/basic.sssom2.rdf"
pytest tests/test_parsers.py -k test_parse_sssom_rdf
sssom-schema
to 0.15.0 [poetry add sssom-schema@0.15.0
]pytest tests/test_parsers.py -k test_parse_sssom_rdf
again