Fix SSSOM Schema not having bijective prefix map #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
approved these changes
Jul 25, 2023
|
@hrshdhgd When you tink this is good to go, can you merge it and make a new release? |
cthoyt
commented
Jul 25, 2023
|
Actually hold on ... there still seems more removing to be done. |
cthoyt
added a commit
that referenced
this pull request
Jul 25, 2023
This PR does not change the underlying schema, it just runs `make all` This also motivates some kind of CI check that when the schema is updated, then this gets run. I want to do this to reduce spurious diff in #302
Merged
cthoyt
added a commit
that referenced
this pull request
Jul 25, 2023
|
everything in this is looking good now |
cthoyt
added a commit
to mapping-commons/sssom-py
that referenced
this pull request
Jul 25, 2023
This was possible thanks to mapping-commons/sssom#302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues in mapping-commons/sssom-py#397 because the base schema does not have a valid prefix map -
dcanddctermsare both used as prefixes for the same URI prefix. This happens because LinkML makes some inference about what needs to be there - there are some assorted uses throughout the schema definition with both DC and DCTERMS. This PR updates the schema to only use DCTERMS and puts explicit entries for DCTERMS in the prefix map to address this. It then regenerates the whole project.