Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make all #303

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Run make all #303

merged 1 commit into from
Jul 25, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Jul 25, 2023

This PR does not change the underlying schema, it just runs make all

This also motivates some kind of CI check that when the schema is updated, then this gets run.

I want to do this to reduce spurious diff in #302

This PR does not change the underlying schema, it just runs `make all`

This also motivates some kind of CI check that when the schema is updated, then this gets run.

I want to do this to reduce spurious diff in #302
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues here. @hrshdhgd you can merge

@cthoyt cthoyt merged commit a553df4 into master Jul 25, 2023
3 checks passed
@cthoyt cthoyt deleted the run-make-all branch July 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants