Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): build product details page #19

Merged
merged 5 commits into from
Dec 11, 2022
Merged

feat(UI): build product details page #19

merged 5 commits into from
Dec 11, 2022

Conversation

mapra99
Copy link
Owner

@mapra99 mapra99 commented Dec 9, 2022

This PR builds the UI for the product details page /products/:slug

Mobile
Tablet
Desktop

@mapra99 mapra99 requested a review from ImMPrada December 9, 2022 13:13
@mapra99
Copy link
Owner Author

mapra99 commented Dec 9, 2022

Closes #17

@mapra99 mapra99 linked an issue Dec 9, 2022 that may be closed by this pull request
Build product page #17
Closed
ImMPrada
ImMPrada approved these changes Dec 11, 2022
View reviewed changes
Copy link
Collaborator

@ImMPrada ImMPrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool cool

Just one thing: there is a warning at app/components/product-features/index.ts for the EOF

@mapra99
Copy link
Owner Author

mapra99 commented Dec 11, 2022

done @ImMPrada, thanks for catching it!

@mapra99 mapra99 merged commit 2606524 into main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImMPrada ImMPrada ImMPrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build product page
2 participants
@mapra99 @ImMPrada