Support for PHP 7 #5252
Comments
|
I need it too. We use php7 in our all servers. |
|
Confirm the same error on Arch Linux for PHP7. |
|
As reported in the SWIG issue about PHP 7 support, Francois Laupretre wrote pecl-compat, "a set of C include files whose objective is to minimize the pain of making a PHP extension compatible with PHP 5 and 7". That may be worth considering for PHP MapScript too. |
|
Checking progress on this. I thought I saw a partial patch posted somewhere...I just want to make sure that this ticket has all of the actual progress. |
|
The partial patch was perhaps the one in the GeoMoose issue for OSGeo-Live, I've not pursued that further because I don't have enough experience with the PHP and MapScript APIs. |
|
Thanks, that was it. Thank you for referring to it here. |
|
MS4W also has been updated recently to be PHP7 compliant with everything except php_mapscript. More info here: http://lists.ms4w.com/pipermail/ms4w-users/2016-June/000087.html |
|
@jmkenna - how is the status? Do you know how much funding is needed? |
|
Although the changes in the "PHPNG - Next Generation" wiki look straight forward, the issue is that these changes must be applied for each of mapscript's custom objects. It is much effort. I have already been looking at this on Windows. I would need much more time to really work on this and debug the issues that come up. I am following the SWIG ticket closely, and unfortunately there has been no progress there (to enhance SWIG to support PHP7). I feel that we must proceed to adapt mapscript for PHP7, as waiting for SWIG to adopt it could be a long time away. |
|
We need this too, or we can't upgrade our Ubuntu servers. A contribution to the funding might be possible. Also Debian stretch will be in a "transition freeze" from 2016-11-05 and "soft freeze" (no new packages) from 2017-01-05. It would be a good thing to make it into stretch. |
|
From the PHP 7 transition: PHP support removed from GEOS & MapServer thread on the debian-gis list:
With the lack of progress in both SWIG and PHP MapScript it's quite certain that both won't be ready in time for inclusion in the upcoming Debian stable release. That means no PHP MapScript for Debian stretch users just like Ubuntu xenial users. This has so far not triggered the affected users to contribute to PHP 7 support in PHP MapScript. Regarding UbuntuGIS and the suggestion it provides mapserver builds with PHP 7 support once that's available, there is a lack of manpower in the UbuntuGIS team so those mapserver builds are not likely to appear unless the manpower issue is addressed. |
|
We're another user that needs php7 support. @jmckenna - you understand the issues involved. And I agree that waiting for SWIG would not be practical. Could you estimate the amount of time needed to make the changes and debug? What skills (and level of experience with MapServer) would contributing developers need? It may be that my team could devote some time to this - but it depends on the time investment needed. |
|
PHP 7 MapScript is essential IMHO |
|
I follow this issue for a while and want to share my thought for a work-a-round. To make the mapfile contents dynamic, you could use xml mapfiles. http://mapserver.org/development/rfc/ms-rfc-51.html Sadly, i think you need to rewrite your mapfiles (but that may be less work as writing a new mapscript) , but someone could write a converter :). |
|
Hi Jeff, is there any news about mapscript for PHP7? |
|
We need PHP7 support at our company as well, and I'm available to spend some time on it. I've been looking into writing a replacement PHP extension using native PHPNG but don't want to go in a direction that might not be accepted. Let me know what I can do to help. |
|
@cjcliffe go for it! We need to make this happen, as for now any solution that allows exisiting php mapscript scripts to run is better than the current situation. Aiming for a 7.2 milestone, I would be fine if you were to target php >= 7 only (unless you need 5.x compatibility for yourself of course). |
|
Hi all. After spending too much time changing the existing code for PHP 7 (unfortunately the PHP "Next Generation" docs are very very slim) and running into problems, I noticed the mini-announcement of a development version of SWIG with PHP 7 support, and dove in. The hardest/impossible part for me was that SWIG on Windows requires a full MING32/MSYS build environment, but I somehow made it through that, and was able to compile a "working" mapscript.dll for PHP 7. I was able to get a small PHP7 script to generate a map image from a mapfile, in the browser. Good! More work is to be done before I can post the steps, for Unix etc, and make it all work with cmake (cringe), hence why I was quiet. But seeing the discussion here today, I was forced to mention this now. I think the teamwork can come in for helping to port the various "interface" functions (from the old "php_mapscript.c") into the SWIG wrapper. As was discussed in a past PSC meeting, using SWIG with PHP is better in the long run (when PHP again changes its core we won't ever be in this situation again); but it will mean some breakages in old scripts, so this would definitely be for a major release like 7.2. Anyway, sorry for not posting anything (but you can imagine my joy, I actually yelled out loud, when I saw a simple map image of Canada in my browser, with PHP 7 - I was never so happy to see a map in my life ha), but hopefully this explains things. Of course, another custom-built PHP extension for PHP 7 could be created, but, we'll just be in the same spot again, 10 years from now. Hope this helps (not hinders) discussions here. |
|
Jeff: I’m glad (excited) you’re having success! Does this work warrant an RFC to help guide discussion and document the potential changes users may face? --Steve
From: Jeff McKenna [mailto:notifications@github.com]
Sent: Monday, December 05, 2016 12:11 PM
To: mapserver/mapserver <mapserver@noreply.github.com>
Subject: Re: [mapserver/mapserver] Support for PHP 7 (#5252)
Hi all. After spending too much time changing the existing code for PHP 7 (unfortunately the PHP "Next Generation" docs are very very slim) and running into problems, I noticed the mini-announcement of a development version of SWIG with PHP 7 support, and dove in. The hardest/impossible part for me was that SWIG on Windows requires a full MING32/MSYS build environment, but I somehow made it through that, and was able to compile a "working" mapscript.dll for PHP 7. I was able to get a small PHP7 script to generate a map image from a mapfile, in the browser. Good!
More work is to be done before I can post the steps, for Unix etc, and make it all work with cmake (cringe), hence why I was quiet. But seeing the discussion here today, I was forced to mention this now.
I think the teamwork can come in for helping to port the various "interface" functions (from the old "php_mapscript.c") into the SWIG wrapper.
As was discussed in a past PSC meeting, using SWIG with PHP is better in the long run (when PHP again changes its core we won't ever be in this situation again); but it will mean some breakages in old scripts, so this would definitely be for a major release like 7.2.
Anyway, sorry for not posting anything (but you can imagine my joy, I actually yelled out loud, when I saw a simple map image of Canada in my browser, with PHP 7 - I was never so happy to see a map in my life ha), but hopefully this explains things.
Of course, another custom-built PHP extension for PHP 7 could be created, but, we'll just be in the same spot again, 10 years from now.
Hope this helps (not hinders) discussions here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#5252 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABhm-z6upWN4k-MZw5c4yd1cUdFZ68EKks5rFFOYgaJpZM4HevY8>.
|
|
Steve you are right, it absolutely requires an RFC, it will really help discussion. I'll draft one. |
|
@jmckenna Glad to hear you've made progress; I managed to get the SWIG /w PHP7 support built on Linux here but hadn't gone much further. Sounds like it's still the best option if we don't want to have to re-do this when they inevitably make a new PHP interface. |
|
I've created an initial draft of the RFC at http://mapserver.org/development/rfc/ms-rfc-117.html Will bring this to the PSC, and also discuss this at the next PSC meeting (19 January). |
|
👍 for the draft. |
|
@tigerfoot thanks for the positive feedback. And yes, I got those PHP 7.1.1 notifications too :) |
|
While PHP7 Mapscript with SWIG is still in development, i mad the job with C: https://github.com/bjoernboldt/mapscript-php7 |
|
Hi Jeff, is there any news about mapscript for PHP7? :D |
|
The @bjoernboldt branch compiled into Debian 9, Php 7.0.27-0 + deb9u1, but when loading the generated library: php_mapscript.so, it gave me an internal server error, without any logging. So I decided to use Docker with Debian 8 and Php 5.6. |
a noop for now until the button is pushed in php.port.mk pear-MDB2-mysql: requires php-mysql nedi: requires php-mysql (fixable by updating to nedi 1.6) mapserver: MapServer/MapServer#5252 xcache: not ported to 7.0; opcache recommended instead
|
Are there plans to fix the build for 7.2, or should packagers not bother with the php bits ? |
|
@landryb PHP 7 is unsupported for MapServer 7.2 |
oki, that's what i wanted to know - thanks ! |
|
@rouault Does it mean PHP 7.x mapscript will never be supported or it will be when developers will get paid for this task ? |
|
Hello all. How is the status? |
|
I can review/test #5642 if someone wants to review #5461 we can get these included for the next release? I presume we can then drop the 5.5 and 5.6 PHP CI tests in Travis (which would speed up test builds): https://travis-ci.org/mapserver/mapserver/builds/416091387 |
|
In my opinion it would be best if PHP 5.6 still gets tested as the last PHP 5 version, since one of the benefits of this patch should be that both PHP5 and PHP7 are supported (whereas the SWIG-based PHPNG I assume will be PHP7 only), but 5.5 could definitely be dropped. |
|
per http://php.net/supported-versions.php PHP 5.6 & 7.0 are EOL upstream at the end of the year, imo it'd be a waste of time (and doing a disservice to users in terms of security) to keep supporting them. |
|
PHP 5.x & 7.0 are still supported in distributions like Debian jessie & stretch, Ubuntu trusty & xenial, and CentOS 6. |
I know, and i get your point, but those maintainance-only/LTS distributions won't upgrade mapserver to a new version supporting only php > 7.1 in the master branch... oh well. It's just more pain to support a bazillion of phps. |
|
@landryb A lot of distros don't have any Mapserver packages anyway (Debian & derivatives excepted), and so to help anyone compiling their own Mapserver (perhaps to get some of the other new features and bugfixes) it makes sense to me to at least check that some PHP 5.x version still works - at least so long as it's not making that much extra work. (note that RHEL7 supports PHP 5.4 until > 2024 and afaik doesn't offer an official Mapserver package that will be supported that long) |
|
Those distribution are unlikely to upgrade their mapserver packages, but users of those distributions may choose to build mapserver from source themselves. The mapserver Debian package is backported to Debian stretch, and via OSGeoLive also to Ubuntu xenial in the UbuntuGIS PPA. |
|
Hi, i'm working on making the old "native" php-mapscript work again in this moment. the patches from @bjoernboldt from #5461 work fine in non-thread-safe environment (windows and linux, using apache with prefork or use php as cgi) but not in thread-safe-environment. but this is not a problem any more. thread-safety isnt even needed because there are no module global variables so i could fix my problems from november last year by removing the unneeded and error-throwing code and i can build native php-mapscript on windows and linux now and even travis build (see https://travis-ci.org/AlexanderGabriel/mapserver/builds/442965494 ) works with PHP5.6, 7, 7.1 and 7.2. don't want to promise too much. i'm doing this in my spare time and mapserver team has to merge all that when i'm finished but i'm figuring out a few last little things, cleen up a little bit and will hopefully open a new PR the next days containing the work from @bjoernboldt and me. if anyone wants to play around in the meanwhile, get the code from here: https://github.com/AlexanderGabriel/mapserver/ but this is very volatile in the moment. please use Branch PHP7Native and Commit AlexanderGabriel@fb989f7 And please note the discussion about php-mapscript on mapserver-dev mailing list. |
|
The promised PR: #5682 |
|
@AlexanderGabriel thanks for making this happen. I see #5687 has been merged, which is awesome. Does anyone know what kind of timeline we would be looking at for release? |
|
Ok, seems like the release plan is here; https://github.com/mapserver/mapserver/wiki/MapServer-7.4-Release-Plan tldr; hopefully around april 1st 2019 |
|
Hi guys, so silly question: is it done/working already? I tried to install it in my php7 with commands But it can find nothing. :( With php5 I just run |
|
That mostly is related to the pository you are fetching from, if i look at https://github.com/mapserver/mapserver/blob/master/HISTORY.TXT it seems like it might be working now? |
|
Ok, so anyone knows maybe from what repo I could fetch it? Or maybe I must compile it by myself to make it work now? |
|
Seem like this is the current place for it (for ubuntu at least)
https://launchpad.net/~ubuntugis/+archive/ubuntu/ubuntugis-unstable
|
|
Ubuntu eoan is the first release to have https://launchpad.net/ubuntu/+source/mapserver Since the GIS packages aren't actively maintained in Ubuntu, building it yourself is good option. In Debian were the GIS packages are actively maintained, MapServer 7.4.2 is available for buster via backports, see: |
|
Ta guys. Will check your directions next week. |
|
Hello all, With gdb i managed to figure that the SIGSEV occurs in fe-misc.c but that might not be really helpful. Do you have news about the behavior of php-mapscriptng or php-mapscriptng on Ubuntu or Debian ? (For Fedora its not yet enabled) Kind regards, |
|
Hi PVi, php-mapscript is available via backports for Debian Buster. I'm not using it but this is an easy way to use it without having to build it by youself.
Kind regards |
and others
Ubuntu has disabled support for PHP in their mapserver package because they have switched to PHP 7 for the xenial LTS release.
Debian will also switch to PHP 7 for the stretch release, hence PHP mapscript will be disabled as long as it doesn't support PHP 7.
The extension API changes are documented on the PHP Wiki:
Upgrading PHP extensions from PHP5 to NG
Switching the build to the default PHP (via php-dev) results in this build failure:
The text was updated successfully, but these errors were encountered: