Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapquery.c "No matching record(s) found." filling up logfiles #5706

Closed
computerchemist opened this issue Nov 21, 2018 · 4 comments
Closed

mapquery.c "No matching record(s) found." filling up logfiles #5706

computerchemist opened this issue Nov 21, 2018 · 4 comments

Comments

@computerchemist
Copy link
Contributor

My mapserver wms service log files fill up very quickly with these messages: "No matching record(s) found.", even with 'DEBUG 0'

The frontend is an openlayers query with many layers; sometimes there is no match for the area/filter, this is not an error in itself.

I would suggest that all messages in mapquery.c are changed to only include this verbose output if verbosity is required in debugging - in other words, for all occurrences of
msSetError(MS_NOTFOUND, "No matching record(s) found.", ......

add this following line above the seterror, to only trigger the errormessage (but still exit with an error condition) if debug is required
if( lp->debug >= MS_DEBUGLEVEL_V )

I have been routinely making this change for several versions now but it would be nice if it was in the codebase - comments?

@geographika
Copy link
Member

That change sounds logical to me. Are you able to create a pull request with your change?

@computerchemist
Copy link
Contributor Author

Seth, feel free to add it in!
There are 5 changes in total to make in mapquery.c .

@geographika
Copy link
Member

@computerchemist - you can make these changes yourself directly in GitHub in the browser to create a pull request. See https://help.github.com/articles/editing-files-in-another-user-s-repository/ (I'm assuming you're not familiar with git - apologies if you are!).
This will then trigger the test suite and can be reviewed by others.

@computerchemist
Copy link
Contributor Author

Thanks for the assist, Seth - I've just learned a new trick! :) Pull request raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants