Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed case when drawing legend shapes with style geomtransforms. (#5193) #5233

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

sdlime
Copy link
Member

@sdlime sdlime commented Feb 4, 2016

This should fix issue #5193. If OK, it should be applied to the 6.4 and 7.0 branches. --Steve

@sdlime
Copy link
Member Author

sdlime commented Feb 5, 2016

@tbonfort, what is the preferred method to apply a pull request like this to older branches (7.0 and 6.4). Should I have prepared the pull request against 7.0 instead? --Steve

@tbonfort
Copy link
Member

tbonfort commented Feb 5, 2016

@sdlime it should ideally be based on 6.4. Don't bother too much, it can be easily back ported if not.

@tbonfort
Copy link
Member

tbonfort commented Feb 5, 2016

PS an autotest for this would be useful in the long run

@sdlime
Copy link
Member Author

sdlime commented Feb 5, 2016

Any objection to the solution?

From: Thomas Bonfort [mailto:notifications@github.com]
Sent: Friday, February 05, 2016 4:12 PM
To: mapserver/mapserver mapserver@noreply.github.com
Cc: Lime, Steve D (MNIT) Steve.Lime@state.mn.us
Subject: Re: [mapserver] Fixed case when drawing legend shapes with style geomtransforms. (#5193) (#5233)

@sdlimehttps://github.com/sdlime it should ideally be based on 6.4. Don't bother too much, it can be easily back ported if not.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5233#issuecomment-180592674.

@tbonfort
Copy link
Member

tbonfort commented Feb 5, 2016

I can have a look if you need when I'm back from holiday next week. I'm not familiar with the expression parser so you probably know better than me anyways.

sdlime added a commit that referenced this pull request Feb 19, 2016
Fixed case when drawing legend shapes with style geomtransforms. (#5193)
@sdlime sdlime merged commit 13d259a into MapServer:master Feb 19, 2016
@sdlime
Copy link
Member Author

sdlime commented Feb 19, 2016

I'll back port to the 7.0 and 6.4 branches by hand... --Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants