Change strdup to use MsStrdup throughout codebase #5321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #5277 - fixes Windows memory issues in conjunction with using msFree
The new pull request hopefully addresses the comments from @tbonfort in a previous pull request:
#5313 (comment)
The removal of the replacement
strdup
function inmapstring.c
may mean if any new code doesn't usemsStrdup
then it will crash on Windows (or at least in debugger mode -strdup
still exists even if it is deprecated).