Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strdup to use MsStrdup throughout codebase #5321

Merged
merged 3 commits into from Sep 19, 2016

Conversation

geographika
Copy link
Member

@geographika geographika commented Sep 3, 2016

See issue #5277 - fixes Windows memory issues in conjunction with using msFree

The new pull request hopefully addresses the comments from @tbonfort in a previous pull request:

#5313 (comment)

  • There's still a call to strdup in mapcopy.h
  • The calls to strdup in mapscript should also probably be changed
  • As you noted, you can remove the mapserver provided strdup() function and the HAVE_STRDUP cmake check

The removal of the replacement strdup function in mapstring.c may mean if any new code doesn't use msStrdup then it will crash on Windows (or at least in debugger mode - strdup still exists even if it is deprecated).

@jmckenna jmckenna added this to the 7.0.2 Release milestone Sep 15, 2016
@jmckenna jmckenna merged commit 7865c5f into MapServer:master Sep 19, 2016
@jmckenna
Copy link
Member

jmckenna commented Sep 19, 2016

@geographika can you also create a pull request for this to branch-7-0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants