-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label frame offset with leader line #5326
Label frame offset with leader line #5326
Conversation
Please provide a complete testcase (mapfile+data+request) that reproduces this. |
Hi Thomas, Here it is, data and mapfile: I call it with:
It produces an image like below, see Brussels, Denver and Oslo for example: I have noticed a workaround, and that is to not use "POSITION auto" for the LABEL. If I instead use "POSITION lc", the result is: And that looks correct with respect to the label frame. Now, I just need to find a way to make the leader and label look connected, without using "POSITION cc", since that won't really look good for labels without leader as they would hide the feature. :) Regards, Stephen |
I've attached a fix for this. There was also a bug on the offseted label computations, as in your example the red symbol should also be offseted instead of remaining on the original position. |
applied to branch-7-0 |
Yikes, I prefer the old MapServer 7.0.1 results. I find the branch-7-0 resulting map image confusing in terms of leader lines. |
Ah ok it is the labelframe, which does display properly in the branch-7-0 image. sorry for the noise. |
When using the LEADER for point labels, the GEOMTRANSFORM 'labelpoly' frame around the label gets an offset both vertically and horizontally. See the image below where the bottom-left label has a leader, but the green frame is moved a few pixels down and to the right. The label which rendered without a LEADER has the correct frame around it.
Here is a section of my mapfile for the relevant layer:
Thanks,
Stephen