Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external git submodule "vtm-ext-libs" #23

Closed
devemux86 opened this issue Jun 18, 2016 · 6 comments
Closed

Remove external git submodule "vtm-ext-libs" #23

devemux86 opened this issue Jun 18, 2016 · 6 comments
Milestone

Comments

@devemux86
Copy link
Collaborator

devemux86 commented Jun 18, 2016

We should remove external git submodule vtm-ext-libs.

Native libraries are better hosted inside the repository for easy control and updates.

@devemux86 devemux86 added this to the 0.6.0 milestone Jun 18, 2016
@devemux86
Copy link
Collaborator Author

Related to #14, #16, #20.

@Longri
Copy link

Longri commented Jun 19, 2016

with this changes the vtm-desktop project is broken!

SharedLibraryLoader can not load lib!

I thing it is not good to have three files (vtm-jni-natives.jar) with different content!

@devemux86
Copy link
Collaborator Author

devemux86 commented Jun 19, 2016

I kept the common vtm-jni-natives.jar naming because of the JNI scripts, which by changing the platform pack the same named native package.
Currently we have 2 jars, for Android and Desktop, in different locations with their own content.

So essentially all that changed is the path.
I updated the modules and run external and internal examples to make sure all work fine.
Which Sample is not working?

@Longri
Copy link

Longri commented Jun 19, 2016

vtm-desktop

@devemux86
Copy link
Collaborator Author

devemux86 commented Jun 19, 2016

I don't understand, vtm-desktop is a library and can be used successfully again, provided that natives jar is in the classpath as seen in build.gradle files.

Since there were structure changes, can you try with a fresh local clone of repository?

@Longri
Copy link

Longri commented Jun 19, 2016

Ok, now I understand!

Maybe it will better to reorganize the folder structure!

In my LibGdx projects I put all library projects into a own folder and in the root I have only the launcher projects for destktop, andrid, ios and web.

Example: https://github.com/Longri/gdx-bitmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants