Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol rotation #294

Closed
wants to merge 2 commits into from
Closed

Symbol rotation #294

wants to merge 2 commits into from

Conversation

Longri
Copy link

@Longri Longri commented Feb 16, 2017

I have given the symbolItem the property 'rotate'.
As an example, I have modified the MarkerOverlayActivity (android-example) and the MarkerLayerTest (playground) to rotate the FocusMarker over a timer.

@@ -1,6 +1,7 @@
apply plugin: 'com.android.application'

dependencies {
compile project(':vtm')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need that as have already the vtm-android being a transitive dependency.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it with me, because my Gradle complained!

Copy link
Collaborator

@devemux86 devemux86 Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange..
VTM on Android Studio / Gradle releases should work 'as is' or else we should fix it.
Also Travis has not complained so far about dependencies.
Have you modified or disabled transitive in your Gradle properties somehow?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Gradle properties are empty!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try with a fresh VTM clone and a clean Gradle cache to test if it's a local Gradle build problem.

@devemux86 devemux86 changed the title Rotate SymbolItem Symbol rotation Feb 27, 2017
@devemux86 devemux86 added this to the 0.8.0 milestone Feb 27, 2017
devemux86 pushed a commit that referenced this pull request Feb 27, 2017
devemux86 added a commit that referenced this pull request Feb 27, 2017
@devemux86
Copy link
Collaborator

Thanks!
Merged via 9815365 with some improvements via f7e5544.

  • In SymbolBucket retain current implementation without rotation, until new one gets sufficient testing
  • Use new examples in vtm-android-example and vtm-playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants