Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create vtm-ios-example project #326

Closed
wants to merge 4 commits into from
Closed

create vtm-ios-example project #326

wants to merge 4 commits into from

Conversation

Longri
Copy link

@Longri Longri commented Mar 6, 2017

No description provided.

@devemux86
Copy link
Collaborator

Can you use a different package in vtm-ios-example, like org.oscim.ios.test?

Also are there example classes in vtm-ios which can be removed now?

@Longri
Copy link
Author

Longri commented Mar 6, 2017

I'll check and commit with removed classes from vtm-ios!

@devemux86
Copy link
Collaborator

devemux86 commented Mar 6, 2017

Something else nice would be the vtm-ios-example to use the vtm-ios natives.
You can check how vtm-android-example uses its own in build.gradle.
That way the natives should exist in one place in repository, less space and better maintenance.

- remove natives from vtm-ios-example to use from dependencies of vtm-ios
@Longri
Copy link
Author

Longri commented Mar 6, 2017

vtm-ios is now a pure library without launcher classes!
vtm-ios-example has no natives and use their from ios-vtm

devemux86 pushed a commit that referenced this pull request Mar 6, 2017
@devemux86 devemux86 added this to the 0.8.0 milestone Mar 6, 2017
@devemux86
Copy link
Collaborator

Thanks!
Merged via 7500ca1.

@devemux86 devemux86 closed this Mar 6, 2017
@devemux86
Copy link
Collaborator

I cleaned up a bit the vtm-ios-example build.gradle.

  • In vtm-ios build.gradle do we need the org.oscim.ios.RoboVmLauncher reference?
  • In vtm-ios-example build.gradle the org.oscim.ios.RoboVmLauncher shouldn't be renamed?

@Longri
Copy link
Author

Longri commented Mar 6, 2017

I think both can deleted, but I will try it tomorrow and commit if it ok.

@devemux86
Copy link
Collaborator

I made an announcement in the forum for larger user visibility.

@Longri Longri deleted the iOS-example branch March 29, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants