-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The key "viewport-fit" is not recognized and ignored. ionic v3 and google maps v2 #1637
Comments
Thank you for sending pull request. I will wait it. |
Same here |
@longzheng You need to fix this. Because your pull request. |
Sorry I don’t follow. The fix is working for me well in iOS 11? The viewport-fit rule is defined here https://drafts.csswg.org/css-round-display/#viewport-fit-descriptor |
The problem occurs on iOS10, because the iOS10 is not able to recognize the viewport-fit attribute. |
iOS 10 and below should ignore the viewport-fit attribute and it shouldn’t have any effect? |
Actually no affect, except the error message in console.log. |
Ah ok. I’ll make a fix for it in the next 24 hours! |
PR ready, awaiting review |
Looks good:) Thanks! |
I do want to ask why this bit of viewport code exists in this plugin? In theory the viewport should be determined by the app, and overriding it like this feels a bit conflicting. |
This plugin has to the position, size and z-index of all html elements in native side. If you have improvement, pleased send another pull request please. |
I think most Cordova/Ionic apps should have the viewport set like this already so I'm not sure if an override is necessary at all. If it is in fact necessary, an alternate approach I can think of is read (and overwrite) the values, instead of the whole string so it is not as destructive. |
You think most Cordova/Ionic, but not 100%. 100% means not only ionic, but also DrupalGap, or other cordova extended frameworks, and even pure HTML. |
I'm submitting a ... (check one with "x")
[ ] question
[X] any problem or bug report
[ ] feature request
plugin version: (check one with "x")
[ ] 1.4.x
[X ] 2.0.0-beta2
cordova information: (run
$> cordova plugin list
)Current behavior:
Expected behavior:
The key "viewport-fit" is not recognized and ignored.
Steps to reproduce:
Screen capture or video record:
Related code, data or error log (please format your code or data):
If your problem is solved, please consider small amount donation to this project.
Appreciate for your kindness.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/README.md#buy-me-a-beer
The text was updated successfully, but these errors were encountered: