Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version without crashlytics (or Google Analytics) for F-Droid #1

Closed
pserwylo opened this issue Oct 5, 2015 · 6 comments
Closed

Version without crashlytics (or Google Analytics) for F-Droid #1

pserwylo opened this issue Oct 5, 2015 · 6 comments

Comments

@pserwylo
Copy link

pserwylo commented Oct 5, 2015

I'd love to build this app for distribution with F-Droid, but it depends on the non-free Crashlytics and Google Analytics. Before building, it is relatively straightforward to replace Google Analytics with NoAnalytics, but crashlytics is more difficult. Would you be able to add a gradle build flavour which when invoked, excludes crashlytics and Google Analytics?

pserwylo added a commit to f-droid/fdroiddata that referenced this issue Oct 7, 2015
This was my first attempt at adding an app from the submission queue.
Contains google analytics, replaced with NoAnalytics. Also contains
crashlytics and an as-yet unpublished .jar file for license-gradle-plugin.
The older versions are on jcenter, so this will likely get published
at some point.

Opened an issue at jawg/osm-contributor#1
to see if they can do a build without crashlytics.
ghost pushed a commit to f-droid/fdroiddata that referenced this issue Oct 7, 2015
Add metadata for osm-contributor (but keep disabled due to crashlytics)

This was my first attempt at adding an app from the submission queue.
Contains google analytics, replaced with NoAnalytics. Also contains
crashlytics and an as-yet unpublished .jar file for license-gradle-plugin.
The older versions are on jcenter, so this will likely get published
at some point.

Opened an issue at jawg/osm-contributor#1
to see if they can do a build without crashlytics. Left a note in maintainer
notes pointing to this issue so that hopefully it can get resolved and then
build (because it looks pretty cool).

See merge request !1008
@loicortola
Copy link
Contributor

Hi Peter,
thanks for the issue!
fredszaq is working on it, flavour should be available within the hour.
The tricky thing was that crashlytics is also part of the buildscript...
I see that you're contributing on Android projects.
Would you like to be a part of the project development team?

@pserwylo
Copy link
Author

@loicortola, thanks for the fix, that's great and provides a nice FOSS build with only FOSS dependencies. I must admit though that I've made a mistake. I was going through the list of apps people have asked to be added to F-Droid, and I didn't realise the mechanism behind osm-contributor - users requesting certain regions of interest and get apps specifically built for them and their mapping parties. It's a really cool approach, but unfortunately I don't think it is suitable for F-Droid, which really only distributes traditional .apks (i.e. each user has the same .apk which was built once by F-Droid). Please let me know if I've gotten this wrong, and there is indeed one .apk that can be used for all users.

As for contributing to this app, I'll keep an eye on your progress because I think it is cool and I also love the OSM project in general. But I have a huge amount of other commitments right now. All the best with this project.

@fredszaq
Copy link
Contributor

@pserwylo the store falvor of the app is destined to be published on app stores and should be suitable for f-droid (same apk for all users). We're still working on it through, expect an usable version within the next few weeks

@loicortola
Copy link
Contributor

@pserwylo, exactly as @fredszaq said. One flavour is for mapping parties (all custom), but there is a general-purpose app already available on the store. This is the one flavoured for f-droid.

@mvdan
Copy link

mvdan commented Dec 24, 2015

@loicortola @fredszaq I just had a look at 2.2.2, thanks for your help on a foss build!

It still doesn't build out of the box, though. It requires the builder to sign up for a bing maps api key. We can't work with that - we have thousands of apps.

I see two possible solutions:

  • Publish the api key (even if hidden as a hex/base64 string)
  • Provide a way to build without a bing maps api key

@contrapunctus-1
Copy link

What became of this? I'd like to use this application, but I can't find it on F-Droid...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants