-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version without crashlytics (or Google Analytics) for F-Droid #1
Comments
This was my first attempt at adding an app from the submission queue. Contains google analytics, replaced with NoAnalytics. Also contains crashlytics and an as-yet unpublished .jar file for license-gradle-plugin. The older versions are on jcenter, so this will likely get published at some point. Opened an issue at jawg/osm-contributor#1 to see if they can do a build without crashlytics.
Add metadata for osm-contributor (but keep disabled due to crashlytics) This was my first attempt at adding an app from the submission queue. Contains google analytics, replaced with NoAnalytics. Also contains crashlytics and an as-yet unpublished .jar file for license-gradle-plugin. The older versions are on jcenter, so this will likely get published at some point. Opened an issue at jawg/osm-contributor#1 to see if they can do a build without crashlytics. Left a note in maintainer notes pointing to this issue so that hopefully it can get resolved and then build (because it looks pretty cool). See merge request !1008
Hi Peter, |
@loicortola, thanks for the fix, that's great and provides a nice FOSS build with only FOSS dependencies. I must admit though that I've made a mistake. I was going through the list of apps people have asked to be added to F-Droid, and I didn't realise the mechanism behind osm-contributor - users requesting certain regions of interest and get apps specifically built for them and their mapping parties. It's a really cool approach, but unfortunately I don't think it is suitable for F-Droid, which really only distributes traditional .apks (i.e. each user has the same .apk which was built once by F-Droid). Please let me know if I've gotten this wrong, and there is indeed one .apk that can be used for all users. As for contributing to this app, I'll keep an eye on your progress because I think it is cool and I also love the OSM project in general. But I have a huge amount of other commitments right now. All the best with this project. |
@pserwylo the store falvor of the app is destined to be published on app stores and should be suitable for f-droid (same apk for all users). We're still working on it through, expect an usable version within the next few weeks |
@loicortola @fredszaq I just had a look at 2.2.2, thanks for your help on a foss build! It still doesn't build out of the box, though. It requires the builder to sign up for a bing maps api key. We can't work with that - we have thousands of apps. I see two possible solutions:
|
What became of this? I'd like to use this application, but I can't find it on F-Droid... |
I'd love to build this app for distribution with F-Droid, but it depends on the non-free Crashlytics and Google Analytics. Before building, it is relatively straightforward to replace Google Analytics with NoAnalytics, but crashlytics is more difficult. Would you be able to add a gradle build flavour which when invoked, excludes crashlytics and Google Analytics?
The text was updated successfully, but these errors were encountered: