Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore withXZY fluent setter #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jomu78
Copy link

@jomu78 jomu78 commented Aug 25, 2023

No description provided.

@filiphr
Copy link
Member

filiphr commented Sep 10, 2023

Thanks for this PR @jomu78. I like the idea of it. However, I would prefer if we do not tie ourselves to withXYZ. I would prefer if we offer users to define their own templates that would mark methods as ignored.

If possible this should also be a project specific configuration, since it is related to usage of a specific custom accessor naming strategy I guess.

Another alternative would also be to provide some kind of a hook point (e.g. providing templates in custom accessor naming strategy implementations) that would be able to define if some methods should be implemented or not. Then we can load and check those from the plugin if we have things in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants