Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ANY_REMAING> and <ANY_UNMAPPED> not ignored when inverting #1936

Closed
sjaakd opened this issue Oct 6, 2019 · 1 comment
Closed

<ANY_REMAING> and <ANY_UNMAPPED> not ignored when inverting #1936

sjaakd opened this issue Oct 6, 2019 · 1 comment
Assignees
@sjaakd
Labels
bug
Milestone
1.4.0.Beta1

Comments

@sjaakd
Copy link
Contributor

sjaakd commented Oct 6, 2019

During introducing vale mapping for string I discovered that the OR condition is wrongly implemented in ValueMapping.java.

Consequence: errors on non-existing enum values <ANY_REMAINING> and <ANY_UNMAPPED> while the intention is to ignore these in inverting.

Documentation needs to be more explicit on this area as well.
@sjaakd sjaakd self-assigned this Oct 6, 2019
sjaakd pushed a commit to sjaakd/mapstruct that referenced this issue Oct 6, 2019
mapstruct#1936 <ANY_REMAINING> and <ANY_UNMAPPED> not ignored when in…
975bd20 
…verting
@sjaakd sjaakd added the bug label Oct 6, 2019
@sjaakd sjaakd added this to the 1.4.0 milestone Oct 6, 2019
sjaakd added a commit that referenced this issue Oct 7, 2019
@sjaakd
#1557 & #1936 String-to-enum and enum-to-String (#1938)
507ec1b 
* #1557 making enum-to-string and string-to-enum

* #1936 <ANY_REMAINING> and <ANY_UNMAPPED> not ignored when inverting
@sjaakd
Copy link
Contributor Author

sjaakd commented Oct 7, 2019

resolved and merged to the master

@sjaakd sjaakd closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjaakd sjaakd

Labels
bug
Projects
None yet
Milestone
1.4.0.Beta1
Development

No branches or pull requests
1 participant
@sjaakd