Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Map.computeIfAbsent in NestedTargetPropertyMappingHolder #1951

Closed
Captain1653 opened this issue Oct 20, 2019 · 0 comments · Fixed by #1952
Closed

Use Map.computeIfAbsent in NestedTargetPropertyMappingHolder #1951

Captain1653 opened this issue Oct 20, 2019 · 0 comments · Fixed by #1952
Labels
refactoring
Milestone
1.4.0.Beta1

Comments

@Captain1653
Copy link
Contributor

Captain1653 commented Oct 20, 2019 •
edited
Loading

There are some lines in NestedTargetPropertyMappingHolder :

if( !map.contains(someKey)) {
map.put(someKey, new LinkedHashSet<>());
}
map.get(someKey).add(someValue)

I think we can replace it on map.computeIfAbsent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
1.4.0.Beta1
Development

Successfully merging a pull request may close this issue.

#1951 Use Map.computeIfAbsent in NestedTargetPropertyMappingHolder
2 participants
@Captain1653 @filiphr