Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refill Themes #447

Merged
merged 14 commits into from Sep 13, 2017
Merged

Refill Themes #447

merged 14 commits into from Sep 13, 2017

Conversation

sarahsnow1
Copy link
Member

Overview

Adds methods to set a themed style and configure it with custom label level, detail level, and theme colors. Allows setting label level, detail level, and theme color after themed style has been set. If the current style is not themed, setting these values will do nothing. If an invalid label or detail level is given, the methods throw IllegalArgumentExceptions.

Proposed Changes

  • Adds new ThemedMapStyle and updates RefillStyle to extend it
  • Adds enums for supported theme colors
  • Sets default label levels to the old, "more label" equivalent
  • Adds methods to MapzenMap to allow configuration of theme and theme properties
  • Adds support for restoring theme details on orientation changes
  • Adds test coverage for new features

A follow-up PR will add support for setting the style asynchronously after the map has been loaded

Closes #406

@sarahsnow1 sarahsnow1 merged commit c781e9e into master Sep 13, 2017
@sarahsnow1 sarahsnow1 deleted the 406-refill-themes branch September 13, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant