Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new compass north #163

Merged
merged 2 commits into from Dec 2, 2015
Merged

new compass north #163

merged 2 commits into from Dec 2, 2015

Conversation

souperneon
Copy link
Member

@souperneon
Copy link
Member Author

I picked an icon that can be rotated around the center to indicate changing north as the user rotates the map and in it's default position points North

ecgreb added a commit that referenced this pull request Dec 2, 2015
@ecgreb ecgreb merged commit 1033259 into master Dec 2, 2015
@ecgreb ecgreb removed the in progress label Dec 2, 2015
@ecgreb ecgreb deleted the ekta/compass-icon branch December 2, 2015 17:05
@ecgreb
Copy link
Collaborator

ecgreb commented Dec 2, 2015

@souperneon I think we might need to go a little bigger with the icon. Its kind of hard to click right now. Also the grey circle is difficult to see over the base map color.

image

@souperneon
Copy link
Member Author

@ecgreb I was thinking we add the same white square behind it? If that gets too clunky I can have the circle filled in? How about we try the square first?

@ecgreb
Copy link
Collaborator

ecgreb commented Dec 3, 2015

@souperneon sure we can try that. We'll also need pressed state assets for the icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants