Add compass view #177
Merged
Add compass view #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert north arrow to image button. Solves issue where buttons always appear on top of other views. * Remove transparency for all overlay views.
* Adds intent extra constants for InstructionListActivity * Adds fallback text if destination name is null * Removes hardcoded strings
Now Tangram does the same tangrams/tangram-es@bee4614
Rather than attempting to reposition a compass both view_route_preview.xml and `view_route_mode.xml` declare their own separate instances of `CompassView` that are shown/hidden along with their parent views. The combination of `MainActivity` and `MainPresenter` handle updating all 3 compasses on map rotation and click.
| (findViewById(R.id.starting_point) as TextView).setText(bundle?.getString("destination")) | ||
| (findViewById(R.id.destination) as TextView).setText(R.string.current_location) | ||
| private fun setHeaderOrigins(destination: String, reverse: Boolean) { | ||
| val startTextView = findViewById(R.id.starting_point) as TextView |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dynamic compass to all screens that allows the user to view current map orientation and reset to North.
toString()withname()in direction list header (Route preview view list shows SimpleFeature destination #174)Rather than attempting to re-position a single compass across multiple views both
view_route_preview.xmlandview_route_mode.xmldeclare their own separate instances ofCompassViewthat are shown/hidden along with their parent views so only one is visible at a time. The combination ofMainActivityandMainPresenterhandle updating all 3 instances on map rotation and click.Closes #78 and #174