Refinements for interacting with map in routing mode #194
Conversation
Verify map is moved a minimum distance before triggering resume button show. Do not show on other motion events.
When the user is manually interacting with the map using gestures it should not automatically snap to the current instruction on pager advance. However it should still snap to the current instruction when the user swipes the view pager. This is achieved by tracking the scroll state of the pager to distinguish changes due to user swipe vs. programatic changes.
| @@ -6,13 +6,17 @@ import com.mapzen.valhalla.Instruction | |||
| import com.mapzen.valhalla.Route | |||
|
|
|||
| public interface RoutePresenter { | |||
| companion object { | |||
| public val GESTURE_MIN_DELTA = 0.0001f | |||
There was a problem hiding this comment.
How did you arrive at this number?
There was a problem hiding this comment.
Its an arbitrary pixel value to make sure the user is actually trying to drag the map rather than perform another type of gesture.
There was a problem hiding this comment.
Is certain hardware able to track sub-pixel motion gestures? I hadn't heard of that. Just wondering if it needs to be that fine or not.
There was a problem hiding this comment.
Good point. I'm not certain but [MotionEvent.html#getHistoricalX(int, int)](https://developer.android.com/reference/android/view/MotionEvent.html#getHistoricalX%28int, int%29) does return a float so I'm guessing its within the realm of posibility.
There was a problem hiding this comment.
Alrighty. Can always tweak later if we figure out something.
Refinements for interacting with map in routing mode
Closes #74