Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to enable debug drawing for tiles and labels #201

Merged
merged 3 commits into from Dec 15, 2015

Conversation

matteblair
Copy link
Member

This is mostly to aid in style evaluation and debugging. With tile debug info enabled, the boundaries and coordinates (x, y, zoom) of each tile is made visible. With label debug info enabled, anchor points and bounding boxes for each label are made visible.

I considered making this a single toggle but the label debug drawing is quite slow and usually not needed. Remaining nitpicks:

  • Settings aren't applied until the settings menu is opened (i.e. until a SettingsFragment is created); not sure how to fix this most simply. (Thanks Chuck!)
  • Tile debug info is only applied to new tiles, not already-rendered tiles. This is really a thing that's best fixed within Tangram-ES, so I'll take care of that there.

Closes #167

Initializes `Tangram` debug flags using values stored in shared prefs in `MainActivity#onCreate()`
@ecgreb
Copy link
Collaborator

ecgreb commented Dec 15, 2015

@blair1618 Tangram debug settings will now take effect on app launch.

@tallytalwar
Copy link
Member

This will be good.

ecgreb added a commit that referenced this pull request Dec 15, 2015
Add settings to enable debug drawing for tiles and labels
@ecgreb ecgreb merged commit 3f45b9b into master Dec 15, 2015
@ecgreb ecgreb deleted the debug-draw-settings branch December 15, 2015 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug printout on display for map zoom level
3 participants