Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Orion's email templates for registration, password reset, etc. #3846

Closed
2 tasks done
jhpedemonte opened this issue Mar 29, 2013 · 3 comments
Closed
2 tasks done

Comments

@jhpedemonte
Copy link
Member

We are now using Orion's email APIs. Unfortunately, the Orion code uses its own mail templates and they cannot currently be (easily) overridden. See Orion bug 403261.

Until that bug is fixed, we have several options:

  1. As part of the build step, overwrite the Orion mail templates with our own.
  2. Use Java reflection to change the visibility of the private members in UserEmailUtil.java, which store the mail templates. Then, set them to our own.
  3. Use AspectJ to dynamically intercept the API calls in UserEmailUtil.java and use our mail templates instead.

Tasks:

  • Override Orion templates.
  • Cleanup/additions to template text.
@ghost ghost assigned jhpedemonte Mar 29, 2013
@jhpedemonte
Copy link
Member Author

References:

jhpedemonte added a commit that referenced this issue Apr 3, 2013
Allows us to add Maqetta branding and perform some cleanup.
#3846
@jhpedemonte
Copy link
Member Author

Above commit adds our own email templates (located at maqetta.server.orion/emails). I made minimal changes from the Orion templates, mainly specifying "Maqetta/Orion" instead of simply "Orion".

Todo:

  1. Is "Maqetta/Orion" fine? Or should we just use "Maqetta"?
  2. Any other cleanup/additions to these templates?

Regarding (2), I think it would be good to add some text explaining to the user how they can change the generated password they receive when doing a reset (i.e. load Orion, go to profile page, edit password).

@JonFerraiolo

@JonFerraiolo
Copy link
Member

  1. Is "Maqetta/Orion" fine? Or should we just use "Maqetta"?

We should just say "Maqetta"

jhpedemonte added a commit that referenced this issue Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants