Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Memory Usage #125

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Reduce Memory Usage #125

merged 8 commits into from
Apr 3, 2023

Conversation

calccrypto
Copy link
Collaborator

Combination of in-situ processing, deferred queues, reduced struct work size, and compression with zlib

if a directory has too many subdirectories, subdirectories past
a user provided count will be processed in the same thread as
the parent directory instead of being enqueued
    Use 0 to always enqueue

use -C to set the cutoff point between "small" and "large" directories
when memory limit is reached, push new work into deferred work queue
    memory limit is constantly exceeded since there is no way to predict number of subdirectories a directory has
only process deferred work queue when active work queue is empty
    processing order is different than before, but work is still constantly processed
use -M to set size
    value is divided across threads
in-situ processing
deferred queues,
reduced struct work size
compression with zlib
affected executables
@codecov-commenter
Copy link

Codecov Report

Merging #125 (bbeafb3) into master (9e9d556) will increase coverage by 0.90%.
The diff coverage is 90.17%.

❗ Current head bbeafb3 differs from pull request most recent head b998ef5. Consider uploading reports for the commit b998ef5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   83.47%   84.38%   +0.90%     
==========================================
  Files          43       56      +13     
  Lines        5012     6077    +1065     
  Branches      642      660      +18     
==========================================
+ Hits         4184     5128     +944     
- Misses        564      672     +108     
- Partials      264      277      +13     
Impacted Files Coverage Δ
contrib/performance/performance_pkg/hashdb/gufi.py 100.00% <ø> (ø)
...trib/performance/performance_pkg/hashdb/machine.py 100.00% <ø> (ø)
contrib/performance/gufi_hash.py 93.90% <66.66%> (+15.52%) ⬆️
src/gufi_dir2trace.c 72.07% <76.92%> (+0.64%) ⬆️
src/gufi_dir2index.c 67.41% <79.59%> (-0.22%) ⬇️
...kg/extraction/gufi_query/cumulative_times_terse.py 80.76% <80.76%> (ø)
src/gufi_query/main.c 77.89% <81.81%> (-6.51%) ⬇️
src/bf.c 94.48% <84.21%> (-4.06%) ⬇️
src/utils.c 84.25% <84.81%> (-1.68%) ⬇️
src/gufi_trace2index.c 85.94% <87.03%> (ø)
... and 21 more

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

}
*/
/* fwrite(pwork->xattrs, sizeof(char), pwork->xattrs_len, out); */
/* fwrite(ed->xattrs, sizeof(char), ed->xattrs_len, out); */

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
@calccrypto calccrypto merged commit b9a7084 into master Apr 3, 2023
@calccrypto calccrypto deleted the reduce-memory-usage branch April 3, 2023 21:58
@calccrypto calccrypto mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants