Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree key navigation #145

Closed
amit034 opened this issue Feb 22, 2014 · 14 comments
Closed

tree key navigation #145

amit034 opened this issue Feb 22, 2014 · 14 comments

Comments

@amit034
Copy link

amit034 commented Feb 22, 2014

key navigation doesn't work well in IE-8
its seems that the tree always got focus therfore keypress cause the tree to act. even when im outside the tree.
in FF3.5 the key navigation almost never works.even when tree has focus

@amit034 amit034 closed this as completed Feb 22, 2014
@mar10
Copy link
Owner

mar10 commented Feb 22, 2014

did you close this issue intentionally?

@mar10
Copy link
Owner

mar10 commented Mar 3, 2014

It seems to work here
http://wwwendt.de/tech/fancytree/demo/sample-form.html
http://wwwendt.de/tech/fancytree/demo/sample-multi-ext.html
tested on IE 11 in 7/8 mode. Can you confirm that it only happens with original IE 8 browsers?
I currently have FF 3.5 available. Can you give some more information such as Console output, etc.

@amit034
Copy link
Author

amit034 commented Mar 3, 2014

yes. i have to work on the originally IE8 :(

@mar10
Copy link
Owner

mar10 commented Mar 3, 2014

I meant: can you confirm that it does not happen on IE 10 or 11, when you enable 8-mode there?
An do yoe see anything on the console?

@mar10
Copy link
Owner

mar10 commented Mar 3, 2014

Maybe related to #65 ?

@amit034
Copy link
Author

amit034 commented Mar 4, 2014

Yes it works on ie10 ie8 mode , and yes backspace is part of the key navigation but not only delete and arrow keys also part of it I think it relate to the problem that the tree blur in וe8 doesn't change the hasfocus state

@mar10
Copy link
Owner

mar10 commented Mar 4, 2014

Ok, thanks for checking this; I will handle this in the first issue #65

@mar10 mar10 closed this as completed Mar 4, 2014
@amit034
Copy link
Author

amit034 commented Mar 5, 2014

meanwhile as a workaround I've disabled the key navigation by setting the 'keyboard' tree option to false

@mar10
Copy link
Owner

mar10 commented Mar 7, 2014

I tried with native IE 8 and the current code seemed to work.
Can you reproduce with the current code from master (i.e. 2.0.0-7 pre)?
Best would be a step-by-step explanation (fopr oine of the sample pages in the example browser, if possible)

@mar10 mar10 reopened this Mar 7, 2014
@mar10
Copy link
Owner

mar10 commented Mar 7, 2014

The OP of #65 just reported this 'closed', can you confirm?

@mar10
Copy link
Owner

mar10 commented Mar 11, 2014

Have you tested with 2.0.0-7?

@amit034
Copy link
Author

amit034 commented Mar 11, 2014

im not on the project anymore i move the issue to other person and the will
probable contact you as soon the will take the latest version.
i worked on development version not sure which one :)

On Tue, Mar 11, 2014 at 9:23 AM, Martin Wendt notifications@github.comwrote:

Have you tested with 2.0.0-7?

Reply to this email directly or view it on GitHubhttps://github.com//issues/145#issuecomment-37269224
.

@mar10
Copy link
Owner

mar10 commented Mar 11, 2014

thanks a lot for contributing !

@mar10
Copy link
Owner

mar10 commented Mar 12, 2014

confirmed closed in #65

@mar10 mar10 closed this as completed Mar 12, 2014
@mar10 mar10 added this to the 2.0.0beta milestone May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants