Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore not succeeded executions in cost calculation #36

Merged
merged 1 commit into from Apr 29, 2020
Merged

ignore not succeeded executions in cost calculation #36

merged 1 commit into from Apr 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2020

We don't want to include broken executions in the node cost calculation. Not succeeded node executions normally don't have an realistic execution time.

We don't want to include broken executions in the node cost calculation; not succeeded node executions normally don't have an realistic execution time.
Copy link
Member

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-loetzsch
Copy link
Member

Indeed a no-brainer, thanks!

@martin-loetzsch martin-loetzsch merged commit 05f1eba into mara:master Apr 29, 2020
@martin-loetzsch
Copy link
Member

It's in master, we will make a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants