Fix CopyIncrementally with no data #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have that for partitioned tables where the time based query does not find any data for several hours.
jankatins
commented
Oct 27, 2020
| @@ -163,7 +165,7 @@ def target_db_alias(self): | |||
| return self._target_db_alias or config.default_db_alias() | |||
|
|
|||
| def file_path(self) -> pathlib.Path: | |||
| return self.parent.parent.base_path() / self.file_name | |||
| return self.parent.parent.base_path() / self.sql_file_name | |||
There was a problem hiding this comment.
This should have error'd -> not used?
martin-loetzsch
added a commit
that referenced
this pull request
Mar 8, 2021
- Fix CopyIncrementally with no data (#54) - Add ability to specify modification value type in CopyIncrementally (#53) 66e7dc1 Jan Katins <jan.katins@zenjob.com> 4. Mar 2021 at 22:06 - Fix read stderr during command execution (#47) - Use echo_queries from mara_db.config.default_echo_queries (#58) - Include all versioned package files in wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing is the last commit which handled the case that the last modification comparison query does not return any value but still succeeds (=would load no data). In that case we now succeed the copy task but don't actually attempt to load data.
This also adjusts the printed messages from Copy to be more readable (I hope) and adds imports and asserts to make my IDE happy...