Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure, make install, AppStream, Flatpak, ioctl #43

Closed
wants to merge 30 commits into from

Conversation

Danysan1
Copy link
Contributor

@Danysan1 Danysan1 commented Dec 24, 2016

To install all files into $exampleDir run:
./configure --prefix=$exampleDir
make
make install

To install all files into $exampleDir run:
INSTALL_ROOT=$exampleDir make install
@Danysan1
Copy link
Contributor Author

For some reason 'make install' still does not install translation files. I am trying to understand why.

@Danysan1 Danysan1 changed the title Prepare "make install", create appdata.xml configure+make+make install & Flatpak support Dec 31, 2016
@Danysan1 Danysan1 force-pushed the patch-1 branch 2 times, most recently from 5309564 to 095658a Compare January 1, 2017 21:27
@Danysan1
Copy link
Contributor Author

Danysan1 commented Jan 2, 2017

Summing up the changes of this pull:

  • radeon-profile/radeon-profile.pro
    Implemented the automated installation through the Makefile install target. After running qmake and make, running make install will automatically install all the files (see below for the exact directories).
  • radeon-profile/configure
    This script automatically collects CXXFLAGS, installation prefix and other info and calls qmake (whether it is from Qt5 or Qt4).

In combination with the first point, this completes the standard linux 3-step build process; running inside the radeon-profile directory the command sequence:

./configure --prefix=...
make
make install DESTDIR=...  INSTALL_ROOT=...

will install these files:

$INSTALL_ROOT/$DESTDIR/$PREFIX/bin/radeon-profile
$INSTALL_ROOT/$DESTDIR/$PREFIX/share/icons/hicolor/512x512/apps/radeon-profile.png
$INSTALL_ROOT/$DESTDIR/$PREFIX/share/applications/radeon-profile.desktop
$INSTALL_ROOT/$DESTDIR/$PREFIX/share/appdata/radeon-profile.appdata.xml
$INSTALL_ROOT/$DESTDIR/$PREFIX/share/radeon-profile/strings.*.qm

This allows to simplify the packaging scripts, automating the install process (for example, old PKGBUILD->new PKGBUILD, old debian.rules->new debian.rules, old .spec->new .spec).
I moved the icon from /share/pixmaps/ to /share/icons/hicolor/512x512/apps/ because that's the path structure where the Freedesktop standard suggests to put the icons.

@Danysan1 Danysan1 changed the title configure+make+make install & Flatpak support configure, make install, AppStream, Flatpak, ioctl Jan 7, 2017
@marazmista
Copy link
Owner

Instead of changing title and push into one pull request as much changes as you can, please do small pull request for each feature when you consider it complete and tested because, when you make a pull request and then still keep committing changes after which code looks nothing like it was when pull request was opened, it is impossible to review.

@Danysan1
Copy link
Contributor Author

Danysan1 commented Jan 8, 2017

Ok, I have solved merge conflicts and split this pull in four parts:

  1. IOCTLs: Diff, Branch, Pull request
  2. Configure, make install, flatpak: Diff, Branch
  3. Fixes to PROFILE power method: Diff, Branch
  4. Fixes for FGLRX driver, improved first data read, splash screen: Diff, Branch

(If you want to merge the separate branches, merge them in this order)
EDIT: I have updated the branches, you can merge them independently in any order

@Danysan1
Copy link
Contributor Author

Leaving the four separate branches to merge, closing.

@Danysan1 Danysan1 closed this Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants