Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that node names don't contain leading/trailing whitespace or commas, and do contain non-whitespace characters #180

Open
fedarko opened this issue Dec 1, 2020 · 0 comments
Labels

Comments

@fedarko
Copy link
Member

fedarko commented Dec 1, 2020

Relates to searching, which I'm currently rewiring back in. This really shouldn't be a problem for most graphs, but I don't believe we explicitly guarantee this anywhere. The reason is that, when the user searches for stuff in the browser, it's natural for them to enter something like

nodeABC, nodeDEF, nodeGHI

... in which case we can figure out the node names they mean by splitting at commas (,) and trimming leading/trailing whitespace. That's all fine. But if any of the node names actually include leading/trailing whitespace, or if they only contain whitespace (lord I hope not), or if they contain commas, then this'll break things.

The solution is really just adding an extra validation step that goes through and checks this. As mentioned, this really shouldn't be a problem, but it's good to be safe.

@fedarko fedarko added the bug label Dec 1, 2020
@fedarko fedarko changed the title Ensure that node names don't contain leading/trailing whitespace, and do contain non-whitespace characters Ensure that node names don't contain leading/trailing whitespace or commas, and do contain non-whitespace characters Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant