fix(core): strict function types for http server types
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JozefFlakus
added
bug
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 24 24
Lines 291 291
Branches 35 35
=====================================
Hits 291 291
Continue to review full report at Codecov.
|
JozefFlakus
changed the title
http server typeshttp server types
sebastianmusial
approved these changes
Jun 3, 2018
| @@ -35,5 +35,5 @@ export const httpListener = ({ | |||
|
|
|||
| effect$.subscribe(); | |||
|
|
|||
| return (req: HttpRequest, res: HttpResponse) => request$.next({ req, res }); | |||
| return (req, res) => request$.next({ req, res }); | |||
There was a problem hiding this comment.
Why did you remove types?
There was a problem hiding this comment.
Because of strict function types for TS compiler. http.IncomingMessage does not conform to HttpRequest which is a wrapper for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
HttpRequestdo not match withhttp.IncomingMessagein strict mode when used withhttp.createServer().urlparameter is marked as optional but should be an required parameter because we are usinghttp.serverIssue Number: #43
What is the new behavior?
HttpResponseandHttpRequestdeclarations inhttpListenerhandler function.2.9.1urltoHttpRequestinterface as not optional parameterDoes this PR introduce a breaking change?