Skip to content

Commit

Permalink
[ticket/14717] Quote strings beginning with @ or % in yaml definitions
Browse files Browse the repository at this point in the history
This type of use was deprecated in symfony 2.8 and will be dropped in 3.x.
Also see: symfony/symfony#16285

PHPBB3-14717
  • Loading branch information
marc1706 committed Jul 23, 2016
1 parent 4554c03 commit 89461d9
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions phpBB/config/default/container/services_auth.yml
Expand Up @@ -103,7 +103,7 @@ services:
auth.provider.oauth.service.twitter:
class: phpbb\auth\provider\oauth\service\twitter
arguments:
- @config
- @request
- '@config'
- '@request'
tags:
- { name: auth.provider.oauth.service }
Expand Up @@ -8,7 +8,7 @@ services:
dbal.conn:
class: phpbb\db\driver\factory
arguments:
- @service_container
- '@service_container'

dispatcher:
class: phpbb\db\driver\container_mock
Expand Down
2 changes: 1 addition & 1 deletion tests/di/fixtures/config/test/container/environment.yml
Expand Up @@ -8,7 +8,7 @@ services:
dbal.conn:
class: phpbb\db\driver\factory
arguments:
- @service_container
- '@service_container'

dispatcher:
class: phpbb\db\driver\container_mock
Expand Down
Expand Up @@ -8,7 +8,7 @@ services:
dbal.conn:
class: phpbb\db\driver\factory
arguments:
- @service_container
- '@service_container'

dispatcher:
class: phpbb\db\driver\container_mock
Expand Down
Expand Up @@ -8,7 +8,7 @@ services:
dbal.conn:
class: phpbb\db\driver\factory
arguments:
- @service_container
- '@service_container'

dispatcher:
class: phpbb\db\driver\container_mock
Expand Down
14 changes: 7 additions & 7 deletions tests/functional/fixtures/ext/foo/bar/config/services.yml
Expand Up @@ -2,13 +2,13 @@ services:
foo_bar.controller:
class: foo\bar\controller\controller
arguments:
- @controller.helper
- @path_helper
- @template
- @config
- @user
- %core.root_path%
- %core.php_ext%
- '@controller.helper'
- '@path_helper'
- '@template'
- '@config'
- '@user'
- '%core.root_path%'
- '%core.php_ext%'

foo_bar.listener.permission:
class: foo\bar\event\permission
Expand Down

0 comments on commit 89461d9

Please sign in to comment.