ARM Neon port for imgproc #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add a license header to it? One problem I've had lingering with imgproc_sse2 is that it includes GPLed code in the transpose helpers. But if you didn't use that code and just reimplemented those (looks to me like it, since the NEON version is quite different?), then we can license this under the LGPL, which I would very much prefer. |
|
Actually, I just did a review of the imgproc_sse2 stuff, and it turns out we can license it as LGPL fully, so please just add the LGPL header :-) |
|
I updated the license header. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported imgproc_sse2.asm to Neon to able compile tracer on a Raspberry Pi.
This should also work with other ARM board that support Neon.
Tested on RPI 2 B with raspbian buster.