-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test + remove buffer options + return nb pages #10
Conversation
Hello! Thanks for your awesome node module! I removed the buffer option in this version (already deprecated in 0.3.0) + the script return a JSON with the number of pages in the PDF! I also updated the README and the documentation! I you like it, don’t forget to `npm publish` :) Regards, Sebastien
Thank you for your contribution. |
Thank you :) |
I added the tests for Travis and AppVeyor too! |
@@ -1,3 +1,8 @@ | |||
0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you to do version bumps always in the master branch after a feature is merged. It looks strange if there are that many other commits after creating a changelog with a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You right!
I'd like to have the pages in the response. But sadly this only works if we define a header or footer because we only execute that method when rendering headers or footers. That might look buggy. The travis config is also ok to merge. Can you create a new pull-request only with the travis file? I can merge that directly. I'll implement appveyor separately (for windows tests). With the other things i'd like to wait because I've changed the api a bit. |
I agree, this is annoying that we cannot have the right number of pages without a header or footer given. I think you can forget this pull request if you changed the API, just maybe be inspired for futur changes by what I've done. :) |
Hello!
Thanks for your awesome node module!
I removed the buffer option in this version (already deprecated in
0.3.0) + the script return a JSON with the number of pages in the PDF!
I also updated the README and the documentation!
I you like it, don’t forget to
npm publish
:)Regards,
Sebastien