Signed-off-by: designwaves firstname.lastname@example.org
Fixed deprecated returning to use tap instead on the Connection.url_for
Signed-off-by: designwaves <email@example.com>
Thanks for modernizing. As is though this breaks backwards compatibility with older versions of Ruby. The safe, though more tedious, way is to add String#tap in the extensions file iff String does not have an instance method 'tap'.
OH yes very true....forgot to check for that. Want me to update it?
Actually looked at the extensions file and not sure what I would add quite yet unless you have an idea of what I could add quickly. I'll have to look at it more later tonight or tomorrow.
Something like this:
# implementation ...
end unless ''.respond_to?(:tap)
Updated Extensions to have string#tap and added test case
Updated the code and seems to be working fine (obviously you would have to give the go ahead but I think it is all good. Might want to make sure the tests run for you too cause I had some issues running the test cases so I built a test in my application and copied it
Marcel, does this look sufficient or would you like me to fix anything else in this pull request?