Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reverse complement. #65

Merged
merged 19 commits into from
Mar 25, 2022
Merged

Implement reverse complement. #65

merged 19 commits into from
Mar 25, 2022

Commits on Mar 23, 2022

  1. Add tests for reverse_complement

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    44ae10d View commit details
    Browse the repository at this point in the history

  2. Add stub for reverse complement

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    a5cc537 View commit details
    Browse the repository at this point in the history

  3. Add two C functions for reversing

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1a0390e View commit details
    Browse the repository at this point in the history

  4. Implement reverse_complement method for SequenceRecord

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    9f355ed View commit details
    Browse the repository at this point in the history

  5. Add conversion table

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    a7e75de View commit details
    Browse the repository at this point in the history

  6. Fix test and implementation typos

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    9ac2223 View commit details
    Browse the repository at this point in the history

  7. Add reverse_complement implementation for BytesSequenceRecord

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    8fe35f4 View commit details
    Browse the repository at this point in the history

  8. Fix duplicate code in conversion table generator

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    6fea93b View commit details
    Browse the repository at this point in the history

  9. Add comment on S,W and N complements

    @rhpvorderman
    rhpvorderman committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    afbd803 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Complete reverse complement tests, code contributed by @fjossandon.

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    5930888 View commit details
    Browse the repository at this point in the history

  2. More informative names _reverse_copy and _reverse_complement_copy

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    fb7d8ed View commit details
    Browse the repository at this point in the history

  3. Remove redundant variable

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4ce8067 View commit details
    Browse the repository at this point in the history

  4. Add a comment about code generation

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    d76fa12 View commit details
    Browse the repository at this point in the history

  5. Change row size to columns

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    de6cb35 View commit details
    Browse the repository at this point in the history

  6. Remove boilerplate

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    58245a0 View commit details
    Browse the repository at this point in the history

  7. Remove redundant code

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    a788fa0 View commit details
    Browse the repository at this point in the history

  8. Use f-string for more readable writing

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    fd83851 View commit details
    Browse the repository at this point in the history

  9. Check for None qualities

    @rhpvorderman
    rhpvorderman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b993ceb View commit details
    Browse the repository at this point in the history

  10. Update src/dnaio/_core.pyx 

    Co-authored-by: Marcel Martin <mail@marcelm.net>
    @rhpvorderman @marcelm
    rhpvorderman and marcelm committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f3307fa View commit details
    Browse the repository at this point in the history