Branchless checking for ASCII #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot about this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 20% faster for the ascii check. But 20% faster on something that is not a bottleneck is not really noticable. Still, I don't like wasting compute cycles and this makes the code simpler and without branches.
I have been fiddling a bit with the ascii-check repo. I also added an SSE2 implementation in that repo. SSE2 in particular is a very interesting instruction set because all x86-64 CPUs support it. No exceptions. So it can always be included in the x86-64 builds.
That implementation cuts the ASCII checking time in more than half, so that might be interesting to look at. I will add that later after this is merged.