Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed keylock error handling #23

Merged

Conversation

TimurSungatullin
Copy link
Contributor

Also made sending the request to a separate method. This will allow you to override this method. For example, to add a request retry in case of an error or custom error handling.

@TimurSungatullin
Copy link
Contributor Author

I found the problem is that you are trying to get an error from method raise_for_status. But this method does not return an error, but raised does

@marcelo225
Copy link
Owner

marcelo225 commented May 3, 2023

Hi @TimurSungatullin !
I'm gonna merge your PR pretty soon.
Have you ever run unit tests?

@marcelo225
Copy link
Owner

@TimurSungatullin appreciated for contributing to it

@marcelo225 marcelo225 merged commit 08693df into marcelo225:master May 3, 2023
@TimurSungatullin
Copy link
Contributor Author

Hi @marcelo225
Thank you!
Yes, I ran existing tests and wrote my own, everything went well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants