Adapter

[stof]

As discussed per mail, I added some extension point using the adapter pattern to make it easier to integrate with other frameworks.
The Zend adapter for the access to request params and cookies could probably be improved as I'm quite sure they have an abstraction for cookies too but I never worked with ZF and so someone else will have to improve it later. Currently, it only does special things for the request param (like the previous implementation)

Sorry for the whitespace changes. My IDE is configured to strip trailing whitespaces automatically when saving. You can view the diff without them by adding ?w=1.

The Symfony2 bundle will be available soon

[marcguyer]

Very nicely done. The only drawback is that anyone using ZF1 previously would now need to specify the Zend adapter(s). Not really a big deal.

Looking forward to seeing the Symphony adapter(s).

[stof]

The bundle is here It does not contain the Symfony adapters yet, only the integration with the config but it will come.

What is exactly the goal of the static setMarketingCookie method ? I'm wondering how I should integrate it with Symfony as the phpdoc says it may be used for all request so maybe the bundle should run it automatically.

[marcguyer]

Just pushed some changes, fyi: 848a5d7

I was tempted to change the naming convention to be more ZF-ish like so:

CheddarGetter/Http/Adapter/Interface.php
CheddarGetter/Http/Adapter/Native.php
CheddarGetter/Http/Adapter/Zend.php
CheddarGetter/Client/Adapter/Interface.php
CheddarGetter/Client/Adapter/Curl.php
CheddarGetter/Client/Adapter/Zend.php

...but that's not really a big deal. Maybe what you've done there is more Symphony-like. The ZF1 autoloader works either way.

What is exactly the goal of the static setMarketingCookie method ? I'm wondering how I should integrate it with Symfony as the phpdoc says it may be used for all request so maybe the bundle should run it automatically.

That cookie stores data about a site's raw traffic from the top of the funnel. The method is intended to be used for every request to the marketing site (not existing users' requests). When that cookie is used, CG is informed about how a customer found the client's site and when. With that information, CG can report on the best market sources, time to conversion, real ROI for marketing dollars, effectiveness of promotions/coupons, etc.

[stof]

Well, ZF2 also uses the way I did it, because it cannot use CheddarGetter\Http\Adapter\Interface for namespaced code (the short class name would be a reserved keyword)