Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing fallbackMockImplementation #110

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

skovhus
Copy link
Contributor

@skovhus skovhus commented Feb 7, 2023

Solves #106 #102

This PR adds support for providing a fallbackMockImplementation for mock and deepMock. My primary motivation is to throw in case a mock implementation is not provided.

@skovhus
Copy link
Contributor Author

skovhus commented Feb 20, 2023

@marchaos do you have time to review this?

@marchaos marchaos merged commit c2923a8 into marchaos:master Feb 24, 2023
@marchaos
Copy link
Owner

looks good, thanks!

@skovhus
Copy link
Contributor Author

skovhus commented Feb 24, 2023

@marchaos thanks! I'm curious when you plan to release it?

@skovhus skovhus deleted the add-fallback-mock-implementation branch February 24, 2023 10:25
marchaos pushed a commit that referenced this pull request Feb 24, 2023
@marchaos
Copy link
Owner

hold tight, just releasing now in 3.0.2

@marchaos
Copy link
Owner

marchaos commented Feb 24, 2023

Just released 3.0.2 - might take a minute to be available in npm, but let me know if you can access it!

renovate bot added a commit to STORIS/mvom that referenced this pull request Feb 24, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jest-mock-extended](https://togithub.com/marchaos/jest-mock-extended)
| [`3.0.1` ->
`3.0.2`](https://renovatebot.com/diffs/npm/jest-mock-extended/3.0.1/3.0.2)
|
[![age](https://badges.renovateapi.com/packages/npm/jest-mock-extended/3.0.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/jest-mock-extended/3.0.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/jest-mock-extended/3.0.2/compatibility-slim/3.0.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/jest-mock-extended/3.0.2/confidence-slim/3.0.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>marchaos/jest-mock-extended</summary>

###
[`v3.0.2`](https://togithub.com/marchaos/jest-mock-extended/releases/tag/3.0.2)

[Compare
Source](https://togithub.com/marchaos/jest-mock-extended/compare/3.0.1...3.0.2)

Added
[marchaos/jest-mock-extended#110

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/STORIS/mvom).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuNCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi40In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Vylpes pushed a commit to Vylpes/Droplet that referenced this pull request Sep 14, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [jest-mock-extended](https://github.com/marchaos/jest-mock-extended) | devDependencies | major | [`^2.0.4` -> `^3.0.0`](https://renovatebot.com/diffs/npm/jest-mock-extended/2.0.4/3.0.4) |

---

### Release Notes

<details>
<summary>marchaos/jest-mock-extended</summary>

### [`v3.0.4`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.4)

[Compare Source](marchaos/jest-mock-extended@3.0.3...3.0.4)

-   Updated jest dependencies
-   Updated typescript peerDependencies to allow for typescript 5.\*

### [`v3.0.3`](marchaos/jest-mock-extended@3.0.2...3.0.3)

[Compare Source](marchaos/jest-mock-extended@3.0.2...3.0.3)

### [`v3.0.2`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.2)

[Compare Source](marchaos/jest-mock-extended@3.0.1...3.0.2)

Added marchaos/jest-mock-extended#110

### [`v3.0.1`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.1)

[Compare Source](marchaos/jest-mock-extended@3.0.0...3.0.1)

Allow overriding calledWithFn - see marchaos/jest-mock-extended#96

### [`v3.0.0`](https://github.com/marchaos/jest-mock-extended/releases/tag/3.0.0)

[Compare Source](marchaos/jest-mock-extended@3602a65...3.0.0)

-   Fixed performance issue for marchaos/jest-mock-extended#97. This required a small API change, hence the major version bump. Deep mocking functions with properties is still possible using

```typescript
mockDeep({ funcPropSupport: true });
```

however this comes with a recursive performance cost. We hope to address this in the future.

### [`v2.0.9`](marchaos/jest-mock-extended@c6fdf33...3602a65)

[Compare Source](marchaos/jest-mock-extended@c6fdf33...3602a65)

### [`v2.0.8`](marchaos/jest-mock-extended@2.0.7...c6fdf33)

[Compare Source](marchaos/jest-mock-extended@2.0.7...c6fdf33)

### [`v2.0.7`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.7)

[Compare Source](marchaos/jest-mock-extended@2.0.6...2.0.7)

### Fixes

-   Fix DeepMockProxy type error for objects which are functions and have fields at the same time - marchaos/jest-mock-extended#95

### [`v2.0.6`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.6)

[Compare Source](marchaos/jest-mock-extended@2.0.5...2.0.6)

Support for Jest 28

### [`v2.0.5`](https://github.com/marchaos/jest-mock-extended/releases/tag/2.0.5)

[Compare Source](marchaos/jest-mock-extended@2.0.4...2.0.5)

Fixes:

-   Explicitly Show DeepMockProxy<T> In Readme Example - marchaos/jest-mock-extended#86
-   Fix ESM support by avoiding export default as syntax - marchaos/jest-mock-extended#83
-   Fix TypeError thrown in mockReset/mockClear - marchaos/jest-mock-extended#81

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9-->

Co-authored-by: Renovate Bot <renovate@vylpes.com>
Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/109
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: RenovateBot <renovate@vylpes.com>
Co-committed-by: RenovateBot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants