Adding ravendb_database_tasks metric #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR. I will try to look into it soon. |
marcinbudny
requested changes
Jan 4, 2024
|
Thank you for the review @marcinbudny. I added 88b48e2 to resolve the remarks. |
malhussan
changed the title
marcinbudny
reviewed
Jan 6, 2024
marcinbudny
approved these changes
Jan 7, 2024
|
Version 0.5.0 is now released with this change, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces two new metrics, ravendb_database_active_tasks and ravendb_database_inactive_tasks, to the RavenDB exporter. These metrics provide valuable insights into the active and inactive tasks within the RavenDB database, enhancing the monitoring capabilities of the exporter.
Motivation
The addition of these metrics addresses a gap in the current monitoring capabilities of the RavenDB exporter. By exposing information about active and inactive tasks, users gain a deeper understanding of the database's workload and resource utilization. This is particularly crucial for performance analysis, capacity planning, and proactive issue detection through alerting on inactive tasks.
Edit:
This pull request now adds only one metric:
ravendb_database_tasks