Fix run_all to pick up all files and reject all directories (dots were m... #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e messing up both)
marcisme
pushed a commit
that referenced
this pull request
May 8, 2014
Slightly modified #19 to add a test for the pattern change and remove the directory filter, as directories are already safely ignored.
|
Thanks for the contribution. Did you notice anything specifically that necessitated the filtering of directories? The copy operation itself ignores them, and I wasn't able to find anything else that required filtering them out up front. |
|
Fixed in 0.5.1 |
|
I would have to set things up and test it again (did this a few months ago) but I recall both files and directories getting picked up. In the least, it spent a lot of time looking at them. |
|
The details aren't fresh in my mind either, but I recall that checking up front would stat every file matched, so handling it in the copy was less total IO, which should mean faster startup times on projects with many files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix run_all to pick up all files and reject all directories (dots were messing up both)