Skip to content

Commit

Permalink
refactor(platform-browser): remove deprecated NgProbeToken (angular…
Browse files Browse the repository at this point in the history
…#18760)

BREAKING CHANGE: `NgProbeToken` has been removed from `@angular/platform-browser` as it was deprecated since v4. Import it from `@angular/core` instead.

PR Close angular#18760
  • Loading branch information
ocombe authored and mhevery committed Aug 17, 2017
1 parent 8f41326 commit d7f42bf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 21 deletions.
16 changes: 3 additions & 13 deletions packages/platform-browser/src/dom/debug/ng_probe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,13 @@ export function inspectNativeElement(element: any): core.DebugNode|null {
return core.getDebugNode(element);
}

/**
* Deprecated. Use the one from '@angular/core'.
* @deprecated
*/
export class NgProbeToken {
constructor(public name: string, public token: any) {}
}

export function _createNgProbe(extraTokens: NgProbeToken[], coreTokens: core.NgProbeToken[]): any {
const tokens = (extraTokens || []).concat(coreTokens || []);
export function _createNgProbe(coreTokens: core.NgProbeToken[]): any {
exportNgVar(INSPECT_GLOBAL_NAME, inspectNativeElement);
exportNgVar(CORE_TOKENS_GLOBAL_NAME, {...CORE_TOKENS, ..._ngProbeTokensToMap(tokens || [])});
exportNgVar(CORE_TOKENS_GLOBAL_NAME, {...CORE_TOKENS, ..._ngProbeTokensToMap(coreTokens || [])});
return () => inspectNativeElement;
}

function _ngProbeTokensToMap(tokens: NgProbeToken[]): {[name: string]: any} {
function _ngProbeTokensToMap(tokens: core.NgProbeToken[]): {[name: string]: any} {
return tokens.reduce((prev: any, t: any) => (prev[t.name] = t.token, prev), {});
}

Expand All @@ -53,7 +44,6 @@ export const ELEMENT_PROBE_PROVIDERS: core.Provider[] = [
provide: core.APP_INITIALIZER,
useFactory: _createNgProbe,
deps: [
[NgProbeToken, new core.Optional()],
[core.NgProbeToken, new core.Optional()],
],
multi: true,
Expand Down
1 change: 0 additions & 1 deletion packages/platform-browser/src/platform-browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export {Meta, MetaDefinition} from './browser/meta';
export {Title} from './browser/title';
export {disableDebugTools, enableDebugTools} from './browser/tools/tools';
export {By} from './dom/debug/by';
export {NgProbeToken} from './dom/debug/ng_probe';
export {DOCUMENT} from './dom/dom_tokens';
export {EVENT_MANAGER_PLUGINS, EventManager} from './dom/events/event_manager';
export {HAMMER_GESTURE_CONFIG, HammerGestureConfig} from './dom/events/hammer_gestures';
Expand Down
7 changes: 0 additions & 7 deletions tools/public_api_guard/platform-browser/platform-browser.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,6 @@ export declare type MetaDefinition = {
[prop: string]: string;
};

/** @deprecated */
export declare class NgProbeToken {
name: string;
token: any;
constructor(name: string, token: any);
}

/** @stable */
export declare const platformBrowser: (extraProviders?: StaticProvider[]) => PlatformRef;

Expand Down

0 comments on commit d7f42bf

Please sign in to comment.