Switched from hash with indifferent access to plain hash.

Indifferent hashes seem to be pretty slow. This helps things out a bit. Using string keys for keys because they can be injected dynamically by users and thus an attack could be formed if symbols were used. Using symbols for associations.

lib/mongo_mapper/plugins/associations.rb

@@ -23,7 +23,7 @@ def one(association_id, options={}, &extension)
         end
 
         def associations
-          @associations ||= HashWithIndifferentAccess.new
+          @associations ||= {}
         end
 
         def associations=(hash)

lib/mongo_mapper/plugins/associations/base.rb

@@ -9,7 +9,7 @@ class Base
         AssociationOptions = [:as, :class, :class_name, :dependent, :extend, :foreign_key, :in, :polymorphic, :autosave]
 
         def initialize(name, options={}, &extension)
-          @name, @options, @query_options, @original_options = name, {}, {}, options
+          @name, @options, @query_options, @original_options = name.to_sym, {}, {}, options
           options.symbolize_keys!
           options[:extend] = modularized_extensions(extension, options[:extend])
           separate_options_and_conditions

lib/mongo_mapper/plugins/dirty.rb

@@ -62,7 +62,7 @@ def attribute_should_change?(key, old, value)
         end
 
         def value_changed?(key_name, old, value)
-          value = nil if keys[key_name].number? && value.blank?
+          value = nil if keys[key_name.to_s].number? && value.blank?
           old != value
         end
       end

lib/mongo_mapper/plugins/keys.rb

@@ -17,7 +17,7 @@ def inherited(descendant)
         end
 
         def keys
-          @keys ||= HashWithIndifferentAccess.new
+          @keys ||= {}
         end
 
         def key(*args)
@@ -294,7 +294,7 @@ def set_parent_document(key, value)
           end
 
           def read_key(key_name)
-            if key = keys[key_name]
+            if key = keys[key_name.to_s]
               value = key.get(instance_variable_get(:"@#{key_name}"))
               set_parent_document(key, value)
               instance_variable_set(:"@#{key_name}", value)

lib/mongo_mapper/plugins/modifiers.rb

@@ -19,7 +19,7 @@ def decrement(*args)
         def set(*args)
           criteria, updates = criteria_and_keys_from_args(args)
           updates.each do |key, value|
-            updates[key] = keys[key].set(value) if key?(key)
+            updates[key] = keys[key.to_s].set(value) if key?(key)
           end
           collection.update(criteria, {'$set' => updates}, :multi => true)
         end

test/functional/test_userstamps.rb

@@ -17,11 +17,11 @@ class UserstampsTest < Test::Unit::TestCase
     end
 
     should "add belongs_to creator" do
-      @document.associations.keys.should include('creator')
+      @document.associations.keys.should include(:creator)
     end
 
     should "add belongs_to updater" do
-      @document.associations.keys.should include('updater')
+      @document.associations.keys.should include(:updater)
     end
   end
 end

test/unit/test_document.rb

@@ -75,10 +75,10 @@ class Post
     end
 
     should "default associations to inherited class" do
-      Message.associations.keys.should include("room")
-      Enter.associations.keys.should   include("room")
-      Exit.associations.keys.should    include("room")
-      Chat.associations.keys.should    include("room")
+      Message.associations.keys.should include(:room)
+      Enter.associations.keys.should   include(:room)
+      Exit.associations.keys.should    include(:room)
+      Chat.associations.keys.should    include(:room)
     end
   end