Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the PyTest tmpdir feature instead of manually handling temporary directories through tempfile #70

Closed
Shashi456 opened this issue Feb 19, 2018 · 2 comments
Closed

Use the PyTest tmpdir feature instead of manually handling temporary directories through tempfile #70

Shashi456 opened this issue Feb 19, 2018 · 2 comments
Labels
good first issue testing

Comments

@Shashi456
Copy link
Contributor

Shashi456 commented Feb 19, 2018 •
edited by marco-c

There's a nice pytest feature that you can use instead of manually using tempfile: https://docs.pytest.org/en/latest/tmpdir.html.

See also PR #63.
@marco-c marco-c changed the title Using the PyTest Tmpdir Feature instead of Temporary Directory Using the PyTest tmpdir feature instead of manually handling temporary directories through tempfile Feb 19, 2018
@marco-c marco-c changed the title Using the PyTest tmpdir feature instead of manually handling temporary directories through tempfile Use the PyTest tmpdir feature instead of manually handling temporary directories through tempfile Feb 19, 2018
@poush
Copy link
Contributor

poush commented Feb 20, 2018

@marco-c Can I take this up?

@marco-c
Copy link
Owner

marco-c commented Feb 20, 2018

@marco-c Can I take this up?

This is reserved for newcomers (people who haven't touched the code base yet) for the time being. You can pick it up if in a week nobody else has.

@poush poush mentioned this issue Mar 13, 2018
Merged
marxmit7 pushed a commit to marxmit7/autowebcompat that referenced this issue Jan 18, 2019
@yatinmaan @marco-c
Update README.md (marco-c#70)
ba04ae2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marco-c @poush @Shashi456