Use PyTest tmpdir fixture instead of manually handling them #123
Conversation
tests/test_utils.py
Outdated
| @@ -10,20 +9,20 @@ def test_get_bugs(): | |||
| bugs = utils.get_bugs() | |||
| assert(isinstance(bugs, list)) | |||
|
|
|||
| @pytest.fixture(scope='session') | |||
tests/test_utils.py
Outdated
| @@ -10,20 +9,20 @@ def test_get_bugs(): | |||
| bugs = utils.get_bugs() | |||
| assert(isinstance(bugs, list)) | |||
|
|
|||
| @pytest.fixture(scope='session') | |||
| def test_mkdir(tmpdir_factory): | |||
There was a problem hiding this comment.
Use tmpdir and the path as a string is tmpdir.strpath
|
Updated. Please check. |
tests/test_utils.py
Outdated
| utils.mkdir(direc_path) | ||
| def test_mkdir(tmpdir): | ||
| dir_path = tmpdir.strpath + "/test" | ||
| utils.mkdir(dir_path) |
There was a problem hiding this comment.
Changing the name of the variable is unnecessary and leads to changes everywhere, it's better to leave it as it was
tests/test_utils.py
Outdated
| @@ -47,12 +45,12 @@ def test_read_labels(): | |||
| assert(isinstance(labels, dict)) | |||
|
|
|||
|
|
|||
| def test_write_labels(): | |||
| @pytest.fixture(scope='session') | |||
There was a problem hiding this comment.
missed it. updated now. Please check.
tests/test_utils.py
Outdated
| file_path = d.name + "/test.csv" | ||
| utils.write_labels(label, file_name=file_path) | ||
| assert(os.path.exists(file_path)) | ||
| fn = tmpdir.mkdir("data").join("test.csv") |
There was a problem hiding this comment.
No need to create a new directory, use tmpdir directly.
Also, don't change the name of the variable
tests/test_utils.py
Outdated
|
|
||
|
|
||
| def test_load_image(tmpdir): | ||
| d = TemporaryDirectory() | ||
| fn = tmpdir.mkdir("data").join("Image.jpg") |
There was a problem hiding this comment.
No need to create another directory, use tmpdir directly
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 24.24% 23.91% -0.33%
==========================================
Files 10 10
Lines 693 690 -3
Branches 84 84
==========================================
- Hits 168 165 -3
Misses 524 524
Partials 1 1
Continue to review full report at Codecov.
|
poush
force-pushed
the
fix70
branch
3 times, most recently
from
96f3d4c
to
d6fdf8a
Compare
|
Please provide your feedback on this pull request here. Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences. |
Fixes #70